Allow output_path to be a s3 path #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katxiao
force-pushed
the
store-output-to-s3
branch
from
47a3257
to
b2626df
Compare
katxiao
force-pushed
the
store-results-to-s3
branch
from
a55dd1f
to
ad700a9
Compare
katxiao
force-pushed
the
store-output-to-s3
branch
from
b2626df
to
7ec0626
Compare
csala
suggested changes
May 18, 2021
sdgym/benchmark.py
Outdated
| if output_path: | ||
| scores.to_csv(output_path, index=False) | ||
|
|
||
| _write_output_to_csv(scores, output_path, aws_key, aws_secret) |
There was a problem hiding this comment.
After comments from #77 are addressed this can become a one line change to write_csv(scores, output_path)
katxiao
force-pushed
the
store-results-to-s3
branch
from
ad700a9
to
39fd695
Compare
katxiao
force-pushed
the
store-output-to-s3
branch
from
7ec0626
to
ab0d8aa
Compare
katxiao
force-pushed
the
store-results-to-s3
branch
from
39fd695
to
5c29ab0
Compare
katxiao
force-pushed
the
store-output-to-s3
branch
from
ab0d8aa
to
a730077
Compare
katxiao
force-pushed
the
store-results-to-s3
branch
from
5c29ab0
to
9c5536c
Compare
katxiao
force-pushed
the
store-output-to-s3
branch
from
a730077
to
bc28e15
Compare
katxiao
force-pushed
the
store-results-to-s3
branch
from
9c5536c
to
ea87801
Compare
katxiao
force-pushed
the
store-output-to-s3
branch
from
bc28e15
to
283780c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user passes
output_pathas an s3_path (s3://<bucket-name>/path/to/dir), the results are stored in the corresponding path of the given bucket. Ifaws_keyandaws_secretare provided, they will be used to authenticate the s3 requests.✅ Ran with aws credentials and a private s3 bucket, and verified that the output file was uploaded.
Resolve #80