Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.10 and drop 3.6 #171

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Support Python 3.10 and drop 3.6 #171

merged 6 commits into from
Jan 25, 2023

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Dec 23, 2022

Resolves #170

@katxiao katxiao changed the title Support Python 3.10 and 3.11, drop 3.6 Support Python 3.10 and drop 3.6 Jan 18, 2023
@katxiao katxiao force-pushed the issue-170-python-support branch 3 times, most recently from 4f0f513 to a650f67 Compare January 23, 2023 22:30
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Base: 24.91% // Head: 25.35% // Increases project coverage by +0.43% 🎉

Coverage data is based on head (9912b5a) compared to base (11a4cd1).
Patch coverage: 34.97% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   24.91%   25.35%   +0.43%     
==========================================
  Files          25       25              
  Lines        2099     2142      +43     
==========================================
+ Hits          523      543      +20     
- Misses       1576     1599      +23     
Impacted Files Coverage Δ
sdgym/metrics.py 24.39% <0.00%> (-2.64%) ⬇️
sdgym/synthesizers/base.py 26.31% <ø> (+0.45%) ⬆️
sdgym/benchmark.py 14.50% <10.00%> (+0.98%) ⬆️
sdgym/datasets.py 31.49% <34.28%> (+1.86%) ⬆️
sdgym/synthesizers/sdv.py 53.40% <50.00%> (+0.46%) ⬆️
sdgym/utils.py 29.75% <82.35%> (+8.59%) ⬆️
sdgym/synthesizers/generate.py 86.36% <86.36%> (ø)
sdgym/__init__.py 100.00% <100.00%> (ø)
sdgym/synthesizers/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@katxiao katxiao marked this pull request as ready for review January 24, 2023 02:04
@katxiao katxiao requested a review from a team as a code owner January 24, 2023 02:04
@katxiao katxiao requested review from pvk-developer and amontanez24 and removed request for a team January 24, 2023 02:04
CONTRIBUTING.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One SDV 0.18.0 is out we can bum that and merge

@katxiao katxiao merged commit bd629d0 into master Jan 25, 2023
@katxiao katxiao deleted the issue-170-python-support branch January 25, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python Versions >=3.7 and <3.11
4 participants