Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #217

Merged
merged 9 commits into from
May 5, 2023
Merged

Refactor code #217

merged 9 commits into from
May 5, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Apr 13, 2023

Resolve #215.

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Patch coverage: 25.16% and project coverage change: +10.24 🎉

Comparison is base (0e3fc24) 30.70% compared to head (8e9cd82) 40.94%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #217       +/-   ##
===========================================
+ Coverage   30.70%   40.94%   +10.24%     
===========================================
  Files          25       19        -6     
  Lines        2140     1231      -909     
===========================================
- Hits          657      504      -153     
+ Misses       1483      727      -756     
Impacted Files Coverage Δ
sdgym/cli/__main__.py 0.00% <0.00%> (ø)
sdgym/errors.py 100.00% <ø> (ø)
sdgym/s3.py 89.47% <ø> (+29.17%) ⬆️
sdgym/synthesizers/__init__.py 100.00% <ø> (ø)
sdgym/utils.py 43.38% <22.22%> (-3.68%) ⬇️
sdgym/cli/utils.py 25.80% <25.80%> (ø)
sdgym/synthesizers/base.py 42.00% <33.33%> (+10.33%) ⬆️
sdgym/benchmark.py 32.92% <56.79%> (+3.09%) ⬆️
sdgym/__init__.py 100.00% <100.00%> (ø)
sdgym/cli/collect.py 27.27% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* Remove MODALITIES

* Remove privbn artifacts

* Add main back

* Add modalities back to datastes
* Remove MODALITIES

* Add main back

* Add modalities back to datastes

* Remove SingleTableSynthesizer

* Fix lint

* Change back SingleTableBaseline

* Revert "Change back SingleTableBaseline"

This reverts commit d47ad9e.
* Initial changes

* Finish relocating files

* Add __init__

* Move args to separate lines

* Delete conda
* Add changes

* Fix MAPPING

* Fix lint

* Remove mapping changes

* Fix lint
* Partial changes

* Add integration tests

* Fix tests, add more

* Add tests

* Remove unneeded changes

* Fix lint

* Loosen test bounds

* Add missing synthesizers

* Loosen restrictions, version 278

* lossen

* Make ranges extremely large

* Add comment

* Fix lint
* Fix UniformSynthesizer

* Finish version one Uniform

* small change

* Add independent synthesizer

* Change Uniform/Independent to match old behavior
@fealho fealho marked this pull request as ready for review May 5, 2023 11:26
@fealho fealho requested a review from a team as a code owner May 5, 2023 11:26
@fealho fealho requested review from frances-h and removed request for a team May 5, 2023 11:26
@fealho fealho merged commit 3c1bffb into master May 5, 2023
@fealho fealho deleted the issue-215-base branch May 5, 2023 11:26
@fealho fealho removed the request for review from frances-h May 5, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Refactoring
2 participants