We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMASynthesizer.update_table_parameters
set_table_parameters
Currently, the method to reset the table parameters is named HMASynthesizer.update_table_parameters.
This does not accurately reflect the functionality:
From looking at the functionality, it appears that we are in the 2nd scenario. So the method is not actually updating, but setting.
Change the method name to: HMASynthesizer.set_table_parameters
HMASynthesizer.set_table_parameters
Try running the following code:
s = HMASynthesizer(metadata) s.update_table_parameters( table_name='users', table_parameters={ 'enforce_min_max_values': False, 'numerical_distributions': { 'A': 'gamma', 'B': 'beta' }}) s.update_table_parameters( table_name='users', table_parameters={ 'numerical_distributions': { 'A': 'uniform'}})
Observe that the end state is:
enforce_min_max_values=True
A='uniform'
This means that the second call for update_table_parameters completely overrides the first -- i.e. this is (re)setting parameters not updating them.
update_table_parameters
The text was updated successfully, but these errors were encountered:
pvk-developer
No branches or pull requests
Problem Description
Currently, the method to reset the table parameters is named
HMASynthesizer.update_table_parameters
.This does not accurately reflect the functionality:
From looking at the functionality, it appears that we are in the 2nd scenario. So the method is not actually updating, but setting.
Expected behavior
Change the method name to:
HMASynthesizer.set_table_parameters
Additional context
Try running the following code:
Observe that the end state is:
enforce_min_max_values=True
andA='uniform'
This means that the second call for
update_table_parameters
completely overrides the first -- i.e. this is (re)setting parameters not updating them.The text was updated successfully, but these errors were encountered: