Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename update_table_parameters to set_table_parameters #1218

Conversation

pvk-developer
Copy link
Member

Resolves #1200

@pvk-developer pvk-developer marked this pull request as ready for review January 31, 2023 13:07
@pvk-developer pvk-developer requested a review from a team as a code owner January 31, 2023 13:07
@pvk-developer pvk-developer requested review from fealho and amontanez24 and removed request for a team January 31, 2023 13:07
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully these files stop sneaking back in 😅

@pvk-developer
Copy link
Member Author

Hopefully these files stop sneaking back in 😅

🙏🏻 I think those are all

@pvk-developer pvk-developer force-pushed the issue-1200-rename-update-table-parameters-to-set-table-parameters branch from 6d93300 to 4994235 Compare February 1, 2023 11:20
@pvk-developer pvk-developer merged commit 79722b4 into V1.0.0.dev Feb 1, 2023
@pvk-developer pvk-developer deleted the issue-1200-rename-update-table-parameters-to-set-table-parameters branch February 1, 2023 17:27
amontanez24 pushed a commit that referenced this pull request Feb 17, 2023
* Rename the function

* Remove missed files.

* Add integration test
amontanez24 pushed a commit that referenced this pull request Mar 23, 2023
* Rename the function

* Remove missed files.

* Add integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants