Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move relational modeling to sdv.relational #198

Closed
csala opened this issue Sep 24, 2020 · 0 comments · Fixed by #199
Closed

Move relational modeling to sdv.relational #198

csala opened this issue Sep 24, 2020 · 0 comments · Fixed by #199
Assignees
@csala
Labels
internal The issue doesn't change the API or functionality
Milestone
0.4.3

Comments

@csala
Copy link
Contributor

csala commented Sep 24, 2020

We currently have the tabular models inside its own subpackage, sdv.tabular, but the relational modeling is handled by the root sdv.SDV class.

This should be moved to a new sdv.relational subpackage and organized as one submodule per algorithm, following the sdv.tabular convention. Also, while doing this change, the old sdv.models can be removed and replaced by the new sdv.tabular models wherever they are being used.

The SDV class should then be adapted to use models from the new subpackage keeping an interface as close to the current one as possible.
@csala csala self-assigned this Sep 24, 2020
@csala csala added the internal The issue doesn't change the API or functionality label Sep 24, 2020
@csala csala added this to the 0.4.3 milestone Sep 24, 2020
csala added a commit that referenced this issue Sep 24, 2020
@csala
Add new sdv.relational subpackage (#198)
3ca57f0
csala added a commit that referenced this issue Sep 24, 2020
@csala
Remove unused old modules (#198)
6c645d4
csala added a commit that referenced this issue Sep 24, 2020
@csala
Update tutorials and fix Table fit (#198)
1e50015
csala added a commit that referenced this issue Sep 24, 2020
@csala
Add user guide for HMA1 (#198)
4f2b01f
@csala csala mentioned this issue Sep 24, 2020
Merged
csala added a commit that referenced this issue Sep 25, 2020
@csala
Merge pull request #199 from sdv-dev/relational-models
b921746 
Movel relational models to sdv.relational (#198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csala csala

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.4.3
Development

Successfully merging a pull request may close this issue.

Relational models sdv-dev/SDV
1 participant
@csala