Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the file_name parameter to filepath parameter in ExcelHandler #2065

Closed
srinify opened this issue Jun 13, 2024 · 0 comments · Fixed by #2093
Closed

Rename the file_name parameter to filepath parameter in ExcelHandler #2065

srinify opened this issue Jun 13, 2024 · 0 comments · Fixed by #2093
Assignees
@lajohn4747
Labels
bug Something isn't working
Milestone
1.15.0

Comments

@srinify
Copy link
Contributor

srinify commented Jun 13, 2024

Problem Description

In the write() method for ExcelHandler, we use file_name instead of filepath.

https://docs.sdv.dev/sdv/multi-table-data/data-preparation/loading-data/excel#write

Reminder: Let's update the docs after release
@srinify srinify added the feature request Request for a new feature label Jun 13, 2024
@lajohn4747 lajohn4747 mentioned this issue Jun 27, 2024
Merged
@lajohn4747 lajohn4747 self-assigned this Jun 27, 2024
@lajohn4747 lajohn4747 added this to the 1.14.1 milestone Jun 27, 2024
@amontanez24 amontanez24 added bug Something isn't working and removed feature request Request for a new feature labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lajohn4747 lajohn4747

Labels
bug Something isn't working
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

Rename the file_name parameter to filepath parameter in ExcelHandler sdv-dev/SDV
3 participants
@srinify @amontanez24 @lajohn4747