Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the file_name parameter to filepath parameter in ExcelHandler #2093

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Rename the file_name parameter to filepath parameter in ExcelHandler #2093

merged 1 commit into from
Jun 28, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #2065
CU-86b0wh82f

@lajohn4747 lajohn4747 requested a review from a team as a code owner June 27, 2024 15:23
@sdv-team
Copy link
Contributor

Task linked: CU-86b0wh82f SDV - Rename the file_name parameter to filepath parameter in ExcelHandler #2065

amontanez24
amontanez24 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to update the docs when this goes out

@lajohn4747 lajohn4747 merged commit 3cbcb47 into main Jun 28, 2024
76 checks passed
@lajohn4747 lajohn4747 deleted the issue_2065_filepath_param branch June 28, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees

@lajohn4747 lajohn4747

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename the file_name parameter to filepath parameter in ExcelHandler
4 participants
@lajohn4747 @sdv-team @amontanez24 @pvk-developer