Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes generator is creating new notes incorrectly #2348

Closed
amontanez24 opened this issue Jan 16, 2025 · 0 comments · Fixed by #2350
Closed

Release Notes generator is creating new notes incorrectly #2348

amontanez24 opened this issue Jan 16, 2025 · 0 comments · Fixed by #2350
Assignees
Labels
bug Something isn't working
Milestone

Comments

@amontanez24
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version: 0.17.4.dev0 or main branch
  • Python version:
  • Operating System:

Error Description

The release notes generator is grabbing one extra character before inserting the new notes. An example can be seen in the PR
#2340 . There is an extra '#' being added.

This is because we are adding 1 to the index that we split the text with in the following line

split_index = history.find(token) + len(token) + 1

Steps to reproduce

  • Run the prepare release workflow
@amontanez24 amontanez24 added the bug Something isn't working label Jan 16, 2025
@amontanez24 amontanez24 self-assigned this Jan 16, 2025
@amontanez24 amontanez24 added this to the 1.17.4 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant