Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing release notes by fixing splitting index #2350

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

amontanez24
Copy link
Contributor

@amontanez24 amontanez24 commented Jan 16, 2025

resolves #2348
The PR #2351 was created using this update. As you can see, the correct amount of '#' characters is being added before the new notes
Screenshot 2025-01-16 at 3 37 26 PM

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (075cdff) to head (425766c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2350   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          59       59           
  Lines        6101     6101           
=======================================
  Hits         6014     6014           
  Misses         87       87           
Flag Coverage Δ
integration 82.18% <ø> (ø)
unit 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontanez24 amontanez24 requested review from rwedge and fealho January 16, 2025 21:36
@amontanez24 amontanez24 marked this pull request as ready for review January 16, 2025 21:36
@amontanez24 amontanez24 requested a review from a team as a code owner January 16, 2025 21:36
@amontanez24 amontanez24 merged commit 67405e3 into main Jan 17, 2025
79 checks passed
@amontanez24 amontanez24 deleted the issue-2348-fix-release-notes branch January 17, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Notes generator is creating new notes incorrectly
4 participants