Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 120 compatibility with rdt issue72 #121

Merged
merged 47 commits into from
Nov 6, 2019

Conversation

JDTheRipperPC
Copy link
Contributor

Resolves #120

Adapted SDV to the new RDT.

@JDTheRipperPC JDTheRipperPC requested a review from csala October 21, 2019 10:48
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 21, 2019

Codecov Report

Merging #121 into master will decrease coverage by 7.24%.
The diff coverage is 86.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   95.66%   88.42%   -7.25%     
==========================================
  Files           8        9       +1     
  Lines         646      570      -76     
==========================================
- Hits          618      504     -114     
- Misses         28       66      +38
Impacted Files Coverage Δ
sdv/evaluation/__init__.py 100% <ø> (ø) ⬆️
sdv/__init__.py 100% <100%> (ø) ⬆️
sdv/demo.py 33.33% <33.33%> (ø)
sdv/modeler.py 85.56% <83.58%> (-7.18%) ⬇️
sdv/sdv.py 87.8% <83.87%> (+21.13%) ⬆️
sdv/metadata.py 87.64% <87.64%> (ø)
sdv/sampler.py 89.3% <91.2%> (-10.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d7b5c...d1376b4. Read the comment docs.

@JDTheRipperPC JDTheRipperPC force-pushed the issue_120_compatibility_with_rdt_issue72 branch from a718fd5 to f7df984 Compare October 21, 2019 11:00
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @JDTheRipperPC and @pvk-developer !

A lot of hard work comes with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compatibility with rdt issue 72
5 participants