-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow me to create a Custom Constraint Class
and use it in the same file (filepath=None
)
#1223
Allow me to create a Custom Constraint Class
and use it in the same file (filepath=None
)
#1223
Conversation
Codecov ReportBase: 95.54% // Head: 95.56% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## V1.0.0.dev #1223 +/- ##
==============================================
+ Coverage 95.54% 95.56% +0.01%
==============================================
Files 44 44
Lines 3547 3559 +12
==============================================
+ Hits 3389 3401 +12
Misses 158 158
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, but then it should be good!
Also I realized there are no integration tests for multi_table
for both load
and add
do you mind adding those ? Or we can address it later.
7650330
to
85c17ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 LG to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good 👍
@@ -10,12 +10,14 @@ def is_valid(column_names, data): | |||
|
|||
def transform(column_names, data): | |||
"""Transform the constraint.""" | |||
return data[column_names] ** 2 | |||
data[column_names] = data[column_names] ** 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
… file (`filepath=None`) (#1223) * Adding method and fixing test * refactoring to store class objects instead of filepaths * adding and fixing unit tests * adding multi-table methods * adding tests * fixing tests * moving name validation to its own method * adding integration tests * fixing integration test
… file (`filepath=None`) (#1223) * Adding method and fixing test * refactoring to store class objects instead of filepaths * adding and fixing unit tests * adding multi-table methods * adding tests * fixing tests * moving name validation to its own method * adding integration tests * fixing integration test
resolves #1205