Make evaluate methods return the actual object #1253
Conversation
Codecov ReportBase: 95.72% // Head: 95.88% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## V1.0.0.dev #1253 +/- ##
==============================================
+ Coverage 95.72% 95.88% +0.15%
==============================================
Files 47 47
Lines 3676 3816 +140
==============================================
+ Hits 3519 3659 +140
Misses 157 157
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fealho
requested review from
amontanez24 and
pvk-developer
and removed request for
a team
sdv/evaluation/single_table.py
Outdated
| quality_report = DiagnosticReport() | ||
| quality_report.generate(real_data, synthetic_data, metadata.to_dict(), verbose) | ||
| return quality_report.get_results() | ||
| return quality_report |
There was a problem hiding this comment.
minor thing I'm noticing now but these variables should probably be named diagnostic_report
sdv/evaluation/multi_table.py
Outdated
| """ | ||
| quality_report = DiagnosticReport() | ||
| quality_report.generate(real_data, synthetic_data, metadata.to_dict(), verbose) | ||
| return quality_report.get_results() | ||
| return quality_report |
* Address feedback * lint * Feedback
* Address feedback * lint * Feedback
* Address feedback * lint * Feedback
Resolve #1190.
Make the evaluate methods return the actual object (
QualityReportandDiagnosticReport) instead of only the score/result.