Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add-on detection for constraints #1412

Merged
merged 3 commits into from
May 9, 2023

Conversation

frances-h
Copy link
Contributor

Resolve #1397

@frances-h frances-h requested a review from a team as a code owner May 8, 2023 16:38
@frances-h frances-h requested review from pvk-developer and removed request for a team May 8, 2023 16:38
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch coverage: 96.15% and project coverage change: -0.05 ⚠️

Comparison is base (898850a) 96.54% compared to head (7c7be2d) 96.49%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   96.54%   96.49%   -0.05%     
==========================================
  Files          48       48              
  Lines        3730     3771      +41     
==========================================
+ Hits         3601     3639      +38     
- Misses        129      132       +3     
Impacted Files Coverage Δ
sdv/constraints/tabular.py 98.89% <83.33%> (-0.36%) ⬇️
sdv/multi_table/base.py 98.45% <83.33%> (-0.50%) ⬇️
sdv/_addons.py 100.00% <100.00%> (ø)
sdv/constraints/__init__.py 100.00% <100.00%> (ø)
sdv/constraints/utils.py 100.00% <100.00%> (ø)
sdv/metadata/anonymization.py 100.00% <100.00%> (ø)
sdv/multi_table/hma.py 81.85% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frances-h frances-h requested a review from fealho May 8, 2023 19:45
@frances-h frances-h merged commit 0f8b92d into master May 9, 2023
@frances-h frances-h deleted the issue-1397-find-constraint-addons branch May 9, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add add-on detection for new constraints
4 participants