Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty tables to be fitted using fit_processed_data #1526

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Allow empty tables to be fitted using fit_processed_data #1526

merged 3 commits into from
Aug 2, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Aug 2, 2023

Resolve #1524.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c4a5230) 96.28% compared to head (c692ae5) 96.28%.
Report is 1 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1526   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          49       49           
  Lines        3934     3935    +1     
=======================================
+ Hits         3788     3789    +1     
  Misses        146      146
Files Changed Coverage Δ
sdv/single_table/base.py 99.28% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review August 2, 2023 03:53
@fealho fealho requested a review from a team as a code owner August 2, 2023 03:53
pvk-developer
pvk-developer reviewed Aug 2, 2023
View reviewed changes
tests/unit/multi_table/test_base.py
# Run
BaseMultiTableSynthesizer.fit_processed_data(instance, data)

# Assert
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we assert that instance._fit has not been called ?

pvk-developer
pvk-developer approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amontanez24
amontanez24 reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Same comment as @pvk-developer

amontanez24
amontanez24 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fealho fealho merged commit 1534b2f into master Aug 2, 2023
@fealho fealho deleted the fit-empty-dataframes branch August 2, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow empty tables to be fitted using fit_processed_data
4 participants
@fealho @codecov-commenter @amontanez24 @pvk-developer