Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphviz install warning if binaries not found #189

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

csala
Copy link
Contributor

@csala csala commented Sep 4, 2020

Resolve #182

@codecov-commenter
Copy link

Codecov Report

Merging #189 into master will increase coverage by 0.50%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   77.87%   78.37%   +0.50%     
==========================================
  Files          22       22              
  Lines        1541     1683     +142     
==========================================
+ Hits         1200     1319     +119     
- Misses        341      364      +23     
Impacted Files Coverage Δ
sdv/metadata/visualization.py 86.27% <16.66%> (-9.29%) ⬇️
sdv/metadata/errors.py 100.00% <0.00%> (ø)
sdv/metadata/table.py 84.49% <0.00%> (+2.22%) ⬆️
sdv/tabular/base.py 67.90% <0.00%> (+3.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35676c9...55e4682. Read the comment docs.

@csala csala merged commit 11d9fd1 into master Sep 7, 2020
@csala csala deleted the issue-182-graphviz-executables branch September 7, 2020 08:44
JonathanDZiegler pushed a commit to JonathanDZiegler/SDV that referenced this pull request Feb 7, 2022
* Add working addons

* Add eradicate

* Add dlint

* Decrease complexity (sdv-dev#184)

* Add addon (sdv-dev#186)

* Add `pytest-style` (sdv-dev#192)

* Add addon

* Fix randomized error message

* Add addon (sdv-dev#188)

* Add addon (#191)

* Add `pandas-vet` (sdv-dev#190)

* Add addon

* noqa torch.stack

* remove double quotes (sdv-dev#187)

* Add addon (sdv-dev#185)

* Add `flake8-docstrings` (sdv-dev#193)

* Add addon

* Fix D100

* Add more docstrings

* Fix docstrings

* Update docstrings

* Fix lint

* Add `flake8-builtins` (sdv-dev#189)

* Add addon

* Add variables-names

* Fix bug

* Fix mistakes

* Add `flake8-multiline-containers` (sdv-dev#183)

* Add addon

* Add addon

* Address feedback

* Fix lint

* Fix bugs

* Remove pydoclint

* Ignore D101 errors

* Update ignores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Message: "make sure the Graphviz executables are on your systems' PATH"
2 participants