Separate primary key detection functionality #2132
Conversation
amontanez24
changed the title
amontanez24
requested review from
gsheni,
frances-h and
pvk-developer
and removed request for
a team and
gsheni
| original_columns = data.columns | ||
| stringified_columns = data.columns.astype(str) | ||
| data.columns = stringified_columns |
There was a problem hiding this comment.
Do we need to do this here and in _detect_columns?
There was a problem hiding this comment.
I think so because the column names that get added to self.columns seem to be the stringified ones. So if we don't do it here then we might get a KeyError
There was a problem hiding this comment.
Actually now that I think about it, this could be a problem for every other function that takes data and looks in the columns. Maybe we should change the dict to store the original column names instead
There was a problem hiding this comment.
But we modified the data so the column names are the stringified ones, no? Then at the end we convert it back to the original column names.
There was a problem hiding this comment.
We also do it at the beginning of _detect_columns and then restore them at the end
There was a problem hiding this comment.
Yeah but the idea is eventually people will call this method on their own
resolves #2101