Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Metadata Class #2135

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Add Metadata Class #2135

merged 2 commits into from
Jul 17, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #2104
CU-86b147dh4

Adds metadata class that inherits MultiTableMetadata for backward compatibility and adds tests to confirm it works fine.

@lajohn4747 lajohn4747 requested a review from a team as a code owner July 16, 2024 18:40
@sdv-team
Copy link
Contributor

Task linked: CU-86b147dh4 SDV - Create unified Metadata class #2104

amontanez24
amontanez24 reviewed Jul 16, 2024
View reviewed changes
sdv/metadata/metadata.py Outdated Show resolved Hide resolved
sdv/metadata/metadata.py Outdated Show resolved Hide resolved
sdv/metadata/metadata.py Outdated Show resolved Hide resolved
sdv/metadata/metadata.py Outdated Show resolved Hide resolved
pvk-developer
pvk-developer approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the Metadata class to sdv/metadata/__init__.py so it can be imported from there.

@lajohn4747 lajohn4747 requested a review from amontanez24 July 17, 2024 15:31
amontanez24
amontanez24 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lajohn4747 lajohn4747 merged commit cd3f1a3 into feature/metadata Jul 17, 2024
39 checks passed
@lajohn4747 lajohn4747 deleted the issue_2104_create_metadata_class branch July 17, 2024 16:47
@lajohn4747 lajohn4747 mentioned this pull request Aug 14, 2024
Merged
R-Palazzo pushed a commit that referenced this pull request Sep 19, 2024
@lajohn4747 @R-Palazzo
Add Metadata Class (#2135)
5f57622
R-Palazzo pushed a commit that referenced this pull request Sep 24, 2024
@lajohn4747 @R-Palazzo
Add Metadata Class (#2135)
b8cdb1d
R-Palazzo pushed a commit that referenced this pull request Sep 26, 2024
@lajohn4747 @R-Palazzo
Add Metadata Class (#2135)
1c1922c
R-Palazzo pushed a commit that referenced this pull request Sep 26, 2024
@lajohn4747 @R-Palazzo
Add Metadata Class (#2135)
089f376
amontanez24 pushed a commit that referenced this pull request Sep 27, 2024
@lajohn4747 @amontanez24
Add Metadata Class (#2135)
094f0ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lajohn4747 @sdv-team @amontanez24 @pvk-developer