Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MultiTableMetadata with Metadata #2146

Merged
merged 11 commits into from
Aug 1, 2024
Merged

Replace MultiTableMetadata with Metadata #2146

merged 11 commits into from
Aug 1, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #2129
CU-86b19awxk

Replace MultiTableMetadata with Metadata and warn the user of deprecation. Since Metadata is a derived class of MultiTableMetadata, almost all instances can be swapped easily. Tests have to change because new instances are created for Metadata conversion and it contains the spec version V1 instead of MULTI_TABLE_V1

@lajohn4747 lajohn4747 requested a review from a team as a code owner July 25, 2024 16:40
@sdv-team
Copy link
Contributor

Task linked: CU-86b19awxk SDV - Enable multi table synthesizers to use new Metadata #2129

@lajohn4747 lajohn4747 requested a review from gsheni July 26, 2024 16:02
gsheni
gsheni approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/integration/metadata/test_metadata.py Outdated Show resolved Hide resolved
@gsheni gsheni assigned gsheni and unassigned lajohn4747 Jul 29, 2024
frances-h
frances-h reviewed Jul 30, 2024
View reviewed changes
sdv/multi_table/base.py Outdated Show resolved Hide resolved
@gsheni gsheni merged commit 034802b into issue_2128_use_metadata_over_single Aug 1, 2024
39 checks passed
@gsheni gsheni deleted the issue_2129_metadata_over_multi branch August 1, 2024 14:55
@gsheni gsheni linked an issue Aug 1, 2024 that may be closed by this pull request
Enable multi table synthesizers to use new Metadata #2129
Closed
@gsheni gsheni mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni approved these changes

@frances-h frances-h frances-h approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

@pvk-developer pvk-developer Awaiting requested review from pvk-developer

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable multi table synthesizers to use new Metadata
6 participants
@lajohn4747 @sdv-team @amontanez24 @gsheni @frances-h @pvk-developer