[dtypes] Numerical Formatter Fails to Learn Format of New Data Types #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Palazzo
commented
Aug 2, 2024
| @@ -55,6 +55,8 @@ class SingleTableMetadata: | |||
| } | |||
|
|
|||
| _NUMERICAL_REPRESENTATIONS = frozenset([ | |||
| 'Float32', | |||
| 'Float64', | |||
There was a problem hiding this comment.
I didn't add a test for this because there is already this test to check the valid computer_representation:
SDV/tests/unit/metadata/test_single_table.py
Line 120 in a0e0a76
amontanez24
approved these changes
Aug 2, 2024
|
|
||
|
|
||
| def test_support_new_pandas_dtypes(): | ||
| """Test that the synthesizer supports the new pandas dtypes.""" |
There was a problem hiding this comment.
Suggested change
| """Test that the synthesizer supports the new pandas dtypes.""" | |
| """Test that the synthesizer supports the nullable numerical pandas dtypes.""" |
pvk-developer
approved these changes
Aug 5, 2024
R-Palazzo
force-pushed
the
issue-2156-numericalformatter
branch
from
05a3ebe to
d608cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b1he00a
CU-86b1gc5jb
Resolve #2156
Resolve #2164
Resolve #2157
#2157 seems to be directly solved by this PR:
