For single-table use cases, make it frictionless to update Metadata #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
issue-2215-validate_table
to
feature/metadata
September 16, 2024 15:13
R-Palazzo
force-pushed
the
issue-2213-frictionless-update-metadata
branch
from
4e62dbe to
2bccb96
Compare
amontanez24
requested changes
Sep 16, 2024
sdv/metadata/metadata.py
Outdated
| @@ -173,7 +173,7 @@ def set_sequence_index(self, table_name, column_name): | |||
| self._validate_table_exists(table_name) | |||
| self.tables[table_name].set_sequence_index(column_name) | |||
|
|
|||
| def set_sequence_key(self, table_name, column_name): | |||
| def set_sequence_key(self, *args, **kwargs): | |||
There was a problem hiding this comment.
I think for all of these we can just use the signature normally. For this one it would be set_sequence_key(self, column_name, table_name). I don't think we have to support a different order
sdv/metadata/metadata.py
Outdated
Comment on lines
258
to
259
| parameters = self._resolve_arguments(['column_name'], *args, **kwargs) | ||
| super().update_column(**parameters) |
There was a problem hiding this comment.
I don't think we need this. Can we just list the args normally and then pass them in the correct order when calling super?
R-Palazzo
added a commit
that referenced
this pull request
Sep 19, 2024
R-Palazzo
added a commit
that referenced
this pull request
Sep 19, 2024
R-Palazzo
added a commit
that referenced
this pull request
Sep 24, 2024
R-Palazzo
added a commit
that referenced
this pull request
Sep 26, 2024
R-Palazzo
added a commit
that referenced
this pull request
Sep 26, 2024
amontanez24
pushed a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2213