Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to drop column in ColumnFormula #531

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Jul 28, 2021

Resolves #508

@katxiao katxiao requested a review from csala July 28, 2021 23:09
@katxiao katxiao force-pushed the sdv-issue-508-column-formula-key-error branch from dc4839d to 74f1e82 Compare July 28, 2021 23:13
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but besides that LGTM!

Input:
- Table data (pandas.DataFrame)
Output:
- Table data without the indicated column (pandas.DataFrame)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say "with the indicated column" right? Since it isn't being dropped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

@katxiao katxiao force-pushed the sdv-issue-508-column-formula-key-error branch from 74f1e82 to 6361425 Compare July 29, 2021 15:14
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csala csala merged commit 3545b4f into master Jul 29, 2021
@csala csala deleted the sdv-issue-508-column-formula-key-error branch July 29, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message for ColumnFormula constraint when constraint column used in formula
3 participants