Update metadata tests #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katxiao
requested review from
pvk-developer and
csala
and removed request for
a team
csala
suggested changes
Nov 4, 2021
| } | ||
| } | ||
| metadata._fields_metadata = { | ||
| 'foo': foo_metadata |
There was a problem hiding this comment.
I suggest creating the other possible types of fields too, so we validate that the if logical checks are correct.
We should at least have:
- A field of type
id, which should be skipped - A field which is neither an
idnorpii, which should also be skipped - A field which is not
idbut ispii, for which mappings should be created
There was a problem hiding this comment.
I added checks for other types of fields in the test__make_anonymization_mappings test. This test__make_anonymization_mappings_unique_faked_value_in_field just tests if there are repeats of a value in the id field.
There was a problem hiding this comment.
Oh! My bad, I missed this. In any case, I like how you laid it out now!
csala
approved these changes
Nov 5, 2021
| } | ||
| } | ||
| metadata._fields_metadata = { | ||
| 'foo': foo_metadata |
There was a problem hiding this comment.
Oh! My bad, I missed this. In any case, I like how you laid it out now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #624