Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to sample remaining columns (3/3) #708

Merged
merged 5 commits into from
Feb 22, 2022
Merged

Add method to sample remaining columns (3/3) #708

merged 5 commits into from
Feb 22, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Feb 10, 2022

Resolves #692

@katxiao katxiao changed the base branch from master to issue-691-create-sample-conditions February 10, 2022 01:00
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022 •
edited
Loading

Codecov Report

Merging #708 (5da1e4b) into issue-691-create-sample-conditions (41d0a18) will increase coverage by 0.47%.
The diff coverage is 94.44%.

Impacted file tree graph

@@                          Coverage Diff                           @@
##           issue-691-create-sample-conditions     #708      +/-   ##
======================================================================
+ Coverage                               65.46%   65.93%   +0.47%     
======================================================================
  Files                                      36       36              
  Lines                                    2615     2657      +42     
======================================================================
+ Hits                                     1712     1752      +40     
- Misses                                    903      905       +2
Impacted Files Coverage Δ
sdv/tabular/base.py 79.64% <94.44%> (+3.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d0a18...5da1e4b. Read the comment docs.

@katxiao katxiao force-pushed the issue-691-create-sample-conditions branch from bc26439 to be49b8e Compare February 10, 2022 22:04
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch from d136a09 to 066cdcd Compare February 10, 2022 22:05
@katxiao katxiao force-pushed the issue-691-create-sample-conditions branch 3 times, most recently from 5f3494e to 9502143 Compare February 11, 2022 01:45
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch from 066cdcd to 129b19f Compare February 11, 2022 01:48
@katxiao katxiao force-pushed the issue-691-create-sample-conditions branch from 9502143 to 619670d Compare February 11, 2022 01:59
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch from 129b19f to f79231a Compare February 11, 2022 02:00
@katxiao katxiao changed the title Add method to sample remaining columns Add method to sample remaining columns (3/3) Feb 11, 2022
@katxiao katxiao marked this pull request as ready for review February 11, 2022 20:03
@katxiao katxiao requested a review from a team as a code owner February 11, 2022 20:03
@katxiao katxiao requested review from pvk-developer and csala and removed request for a team February 11, 2022 20:03
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch 2 times, most recently from bc6e6e2 to b797faf Compare February 11, 2022 22:23
pvk-developer
pvk-developer approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM!

@katxiao katxiao force-pushed the issue-691-create-sample-conditions branch from 619670d to 64c6b64 Compare February 16, 2022 21:58
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch from b797faf to e3e9d67 Compare February 16, 2022 21:58
@katxiao katxiao force-pushed the issue-691-create-sample-conditions branch from 64c6b64 to b3c1f3f Compare February 16, 2022 22:14
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch from e3e9d67 to 3c7135b Compare February 16, 2022 22:14
@katxiao katxiao force-pushed the issue-691-create-sample-conditions branch from b3c1f3f to 512422b Compare February 16, 2022 23:57
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch from 3c7135b to 754b9e1 Compare February 16, 2022 23:58
@katxiao katxiao force-pushed the issue-691-create-sample-conditions branch from 512422b to 1b64e32 Compare February 17, 2022 19:22
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch from 754b9e1 to 640419c Compare February 17, 2022 19:22
@katxiao katxiao requested review from fealho and removed request for csala February 17, 2022 19:23
fealho
fealho reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor details.

docs/user_guides/single_table/copulagan.rst Outdated Show resolved Hide resolved
docs/user_guides/single_table/ctgan.rst Outdated Show resolved Hide resolved
docs/user_guides/single_table/ctgan.rst Outdated Show resolved Hide resolved
docs/user_guides/single_table/gaussian_copula.rst Outdated Show resolved Hide resolved
docs/user_guides/single_table/gaussian_copula.rst Outdated Show resolved Hide resolved
tutorials/single_table_data/02_CTGAN_Model.ipynb Outdated Show resolved Hide resolved
tutorials/single_table_data/02_CTGAN_Model.ipynb Outdated Show resolved Hide resolved
tutorials/single_table_data/03_CopulaGAN_Model.ipynb Outdated Show resolved Hide resolved
tutorials/single_table_data/03_CopulaGAN_Model.ipynb Outdated Show resolved Hide resolved
tutorials/single_table_data/04_TVAE_Model.ipynb Outdated Show resolved Hide resolved
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch 3 times, most recently from 4c38284 to 780a293 Compare February 18, 2022 05:48
@katxiao katxiao requested a review from fealho February 18, 2022 05:48
@katxiao
Copy link
Contributor Author

katxiao commented Feb 18, 2022

Thanks @fealho! I ran make docs to make sure all the docs build properly, and it looks good now.

@katxiao katxiao force-pushed the issue-691-create-sample-conditions branch from 1b64e32 to 41d0a18 Compare February 18, 2022 06:08
@katxiao katxiao force-pushed the issue-692-sample-remaining-columns branch from 780a293 to 32dd6ab Compare February 18, 2022 06:08
fealho
fealho approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@katxiao
Enable batch sampling (#709)
5da1e4b 
* Add batch sampling and progress bar

* Make sure to close progress bar

* Periodically write to file

* add unit tests

* cr comments

* fix test
@katxiao katxiao merged commit d650c20 into issue-691-create-sample-conditions Feb 22, 2022
@katxiao katxiao deleted the issue-692-sample-remaining-columns branch February 22, 2022 19:21
katxiao added a commit that referenced this pull request Feb 22, 2022
@katxiao
Add method to sample remaining columns (3/3) (#708)
c0a7723 
* Add method to sample remaining columns

* update integration tests

* add unit tests

* update tutorials and docs

* Enable batch sampling (#709)

* Add batch sampling and progress bar

* Make sure to close progress bar

* Periodically write to file

* add unit tests

* cr comments

* fix test
katxiao added a commit that referenced this pull request Feb 22, 2022
@katxiao
Add method to sample remaining columns (3/3) (#708)
c9127ae 
* Add method to sample remaining columns

* update integration tests

* add unit tests

* update tutorials and docs

* Enable batch sampling (#709)

* Add batch sampling and progress bar

* Make sure to close progress bar

* Periodically write to file

* add unit tests

* cr comments

* fix test
katxiao added a commit that referenced this pull request Feb 23, 2022
@katxiao
Add method to sample remaining columns (3/3) (#708)
318ffbc 
* Add method to sample remaining columns

* update integration tests

* add unit tests

* update tutorials and docs

* Enable batch sampling (#709)

* Add batch sampling and progress bar

* Make sure to close progress bar

* Periodically write to file

* add unit tests

* cr comments

* fix test
katxiao added a commit that referenced this pull request Feb 23, 2022
@katxiao
Refactor sample API (1/3) (#705)
0dae889 
* Update sample method args

* Add unit tests

* remove conditioning logic for now

* Add error handling

* Make integration tests pass

* code review comments

* Add sample conditions method

* add back unit tests with conditions

* Update logic for handling multiple conditions

* fix lint

* fix integration tests

* Add method to sample remaining columns (3/3) (#708)

* Add method to sample remaining columns

* update integration tests

* add unit tests

* update tutorials and docs

* Enable batch sampling (#709)

* Add batch sampling and progress bar

* Make sure to close progress bar

* Periodically write to file

* add unit tests

* cr comments

* fix test
katxiao added a commit that referenced this pull request Mar 3, 2022
@katxiao
Refactor sample API (1/3) (#705)
b2b817d 
* Update sample method args

* Add unit tests

* remove conditioning logic for now

* Add error handling

* Make integration tests pass

* code review comments

* Add sample conditions method

* add back unit tests with conditions

* Update logic for handling multiple conditions

* fix lint

* fix integration tests

* Add method to sample remaining columns (3/3) (#708)

* Add method to sample remaining columns

* update integration tests

* add unit tests

* update tutorials and docs

* Enable batch sampling (#709)

* Add batch sampling and progress bar

* Make sure to close progress bar

* Periodically write to file

* add unit tests

* cr comments

* fix test
katxiao added a commit that referenced this pull request Mar 4, 2022
@katxiao
Refactor sample API (1/3) (#705)
2018d9e 
* Update sample method args

* Add unit tests

* remove conditioning logic for now

* Add error handling

* Make integration tests pass

* code review comments

* Add sample conditions method

* add back unit tests with conditions

* Update logic for handling multiple conditions

* fix lint

* fix integration tests

* Add method to sample remaining columns (3/3) (#708)

* Add method to sample remaining columns

* update integration tests

* add unit tests

* update tutorials and docs

* Enable batch sampling (#709)

* Add batch sampling and progress bar

* Make sure to close progress bar

* Periodically write to file

* add unit tests

* cr comments

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@fealho fealho fealho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create sample_remaining_columns() method
4 participants
@katxiao @codecov-commenter @fealho @pvk-developer