Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tutorial #727

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Fix flaky tutorial #727

merged 2 commits into from
Mar 8, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Mar 4, 2022

Fix flaky tutorial.

Also resolve #680

@katxiao katxiao requested a review from a team as a code owner March 4, 2022 18:46
@katxiao katxiao requested review from fealho and pvk-developer and removed request for a team and fealho March 4, 2022 18:46
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #727 (4854c53) into master (1b072ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files          36       36           
  Lines        2685     2685           
=======================================
  Hits         1771     1771           
  Misses        914      914           
Impacted Files Coverage Δ
sdv/demo.py 21.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b072ed...4854c53. Read the comment docs.

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katxiao katxiao merged commit ab0d9ad into master Mar 8, 2022
@katxiao katxiao deleted the tutorial-fixes branch March 8, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in the document
3 participants