Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix field distributions bug for copulagan #750

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Fix field distributions bug for copulagan #750

merged 2 commits into from
Mar 30, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Mar 29, 2022

Resolves #747

@katxiao katxiao requested a review from a team as a code owner March 29, 2022 23:34
@katxiao katxiao requested review from pvk-developer and amontanez24 and removed request for a team March 29, 2022 23:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #750 (75fba54) into master (acdceb7) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   67.47%   67.54%   +0.06%     
==========================================
  Files          38       38              
  Lines        2832     2838       +6     
==========================================
+ Hits         1911     1917       +6     
  Misses        921      921
Impacted Files Coverage Δ
sdv/tabular/copulagan.py 89.28% <100.00%> (+2.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdceb7...75fba54. Read the comment docs.

amontanez24
amontanez24 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment but besides that :shipit:

sdv/tabular/copulagan.py Outdated Show resolved Hide resolved
@katxiao katxiao force-pushed the sdv-747-fix-field-distributions-copulagan branch from aa4291c to 0f0cf5d Compare March 30, 2022 15:37
@katxiao katxiao force-pushed the sdv-747-fix-field-distributions-copulagan branch from 0f0cf5d to 75fba54 Compare March 30, 2022 15:43
@katxiao katxiao merged commit 2e7bc13 into master Mar 30, 2022
@katxiao katxiao deleted the sdv-747-fix-field-distributions-copulagan branch March 30, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field distributions bug in CopulaGAN
4 participants
@katxiao @codecov-commenter @amontanez24 @pvk-developer