Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 68: Add support for Vine Copulas as a Modeler, different distributions for Gaussian Copula. #80

Merged
merged 14 commits into from
Feb 5, 2019
Merged

Issue 68: Add support for Vine Copulas as a Modeler, different distributions for Gaussian Copula. #80

merged 14 commits into from
Feb 5, 2019

Conversation

ManuelAlvarezC
Copy link
Contributor

@ManuelAlvarezC ManuelAlvarezC commented Jan 30, 2019 •
edited
Loading

  • Add support for different distributions when using copulas.multivariate.GaussianMultivariate as model.
  • Add support for using copulas.multivariate.VineCopula as model.
  • Improved the flattening of models to adapt to the mentioned changes.
  • Improved the creation of extensions.
  • Raise errors when the new distributions/models are not able to model the given data.
  • Add/Update tests for the specified changes.

This issue resolves #68 and also resolves #71

@ManuelAlvarezC ManuelAlvarezC added feature request Request for a new feature internal The issue doesn't change the API or functionality labels Jan 30, 2019
@csala
Copy link
Contributor

csala commented Feb 4, 2019

@ManuelAlvarezC can you edit the PR title to be a bit clearer about what's in it? This is just to have a clearer history about what went in the PRs in the future, as I feel that the parameter not being used is the least important things of the ones included.

Also, this PR includes no changes in the README. Are all the code changes 100% compatible with the code snippets and examples from the README, or perhaps we should update them as well?

@ManuelAlvarezC ManuelAlvarezC changed the title Issue 68: Modeler parameter not used Issue 68: Add support for Vine Copulas as a Modeler, different distributions for Gaussian Copula. Feb 5, 2019
@ManuelAlvarezC
Copy link
Contributor Author

@csala The title has been updated, and the snippets from the README checked.

@ManuelAlvarezC ManuelAlvarezC merged commit 04b3a34 into master Feb 5, 2019
@ManuelAlvarezC ManuelAlvarezC deleted the 68_modeler_parameter_not_used branch February 5, 2019 10:56
JonathanDZiegler pushed a commit to JonathanDZiegler/SDV that referenced this pull request Feb 7, 2022
@fealho
Merge pull request sdv-dev#80 from sdv-dev/drop-py35
15f6a0b 
Drop Python3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csala csala csala approved these changes

@kveerama kveerama Awaiting requested review from kveerama

Assignees
No one assigned
Labels
feature request Request for a new feature internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Vine Copulas as a modeler. Modeler parameter not being used (?)
2 participants
@ManuelAlvarezC @csala