Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RDT to v1.0.0 #923

Merged
merged 22 commits into from
Aug 2, 2022
Merged

Update RDT to v1.0.0 #923

merged 22 commits into from
Aug 2, 2022

Conversation

pvk-developer
Copy link
Member

Resolves #897

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #923 (e1f7274) into master (50a48a3) will decrease coverage by 0.19%.
The diff coverage is 73.17%.

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
- Coverage   68.72%   68.52%   -0.20%     
==========================================
  Files          38       38              
  Lines        2871     2847      -24     
==========================================
- Hits         1973     1951      -22     
+ Misses        898      896       -2     
Impacted Files Coverage Δ
sdv/constraints/tabular.py 99.73% <ø> (ø)
sdv/relational/hma.py 11.48% <0.00%> (ø)
sdv/sdv.py 89.47% <ø> (ø)
sdv/tabular/base.py 83.85% <ø> (ø)
sdv/tabular/ctgan.py 77.77% <ø> (ø)
sdv/timeseries/base.py 0.00% <ø> (ø)
sdv/metadata/dataset.py 61.49% <20.00%> (-3.30%) ⬇️
sdv/metadata/table.py 81.53% <75.00%> (+0.54%) ⬆️
sdv/constraints/base.py 96.95% <100.00%> (+0.05%) ⬆️
sdv/lite/tabular.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a48a3...e1f7274. Read the comment docs.

@pvk-developer pvk-developer marked this pull request as ready for review July 27, 2022 12:02
@pvk-developer pvk-developer requested a review from a team as a code owner July 27, 2022 12:02
@pvk-developer pvk-developer requested review from fealho and amontanez24 and removed request for a team July 27, 2022 12:02
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments and questions

sdv/metadata/dataset.py Outdated Show resolved Hide resolved
sdv/metadata/table.py Outdated Show resolved Hide resolved
sdv/metadata/table.py Outdated Show resolved Hide resolved
sdv/metadata/table.py Outdated Show resolved Hide resolved
sdv/tabular/base.py Outdated Show resolved Hide resolved
sdv/tabular/copulagan.py Outdated Show resolved Hide resolved
sdv/tabular/copulas.py Outdated Show resolved Hide resolved
sdv/tabular/ctgan.py Outdated Show resolved Hide resolved
sdv/tabular/ctgan.py Outdated Show resolved Hide resolved
tests/unit/metadata/test_dataset.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor comment, but after that looks ready to go to me!

sdv/metadata/table.py Outdated Show resolved Hide resolved
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just double check why the tutorials are failing.

@pvk-developer pvk-developer merged commit b09131f into master Aug 2, 2022
@pvk-developer pvk-developer deleted the issue-897-update-rdt-to-v1.0.0 branch August 2, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the RDT version to 1.0
4 participants