Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 93: Model amount of children #98

Merged
merged 16 commits into from
May 15, 2019
Merged

Issue 93: Model amount of children #98

merged 16 commits into from
May 15, 2019

Conversation

ManuelAlvarezC
Copy link
Contributor

Resolve #93

Allow to model the amount of child rows for each parent row and using it when sampling.

@ManuelAlvarezC ManuelAlvarezC requested review from kveerama and csala May 7, 2019 16:38
@ManuelAlvarezC ManuelAlvarezC changed the title Issue 93: model amount childs Issue 93: Model amount of children May 7, 2019
@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #98 into master will decrease coverage by 1.46%.
The diff coverage is 72.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage    81.4%   79.93%   -1.47%     
==========================================
  Files           5        5              
  Lines         613      608       -5     
==========================================
- Hits          499      486      -13     
- Misses        114      122       +8
Impacted Files Coverage Δ
sdv/modeler.py 91.06% <100%> (-2.01%) ⬇️
sdv/sdv.py 53.33% <60%> (+0.7%) ⬆️
sdv/sampler.py 71.37% <69.51%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff16697...96d266f. Read the comment docs.

sdv/sampler.py Outdated Show resolved Hide resolved
sdv/sdv.py Outdated Show resolved Hide resolved
@ManuelAlvarezC ManuelAlvarezC requested a review from csala May 10, 2019 11:14
@csala csala merged commit 941e4ef into master May 15, 2019
@csala csala deleted the 93_model_amount_childs branch May 15, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to model the amount of child rows
3 participants