Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Guide code fixes #989

Merged
merged 2 commits into from
Sep 1, 2022
Merged

User Guide code fixes #989

merged 2 commits into from
Sep 1, 2022

Conversation

amontanez24
Copy link
Contributor

resolves #983

@amontanez24 amontanez24 requested a review from a team as a code owner August 31, 2022 22:19
@amontanez24 amontanez24 requested review from katxiao and fealho and removed request for a team August 31, 2022 22:19
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022 •
edited
Loading

Codecov Report

Merging #989 (8b594ed) into master (b441913) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #989   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files          38       38           
  Lines        2851     2851           
=======================================
  Hits         2002     2002           
  Misses        849      849
Impacted Files Coverage Δ
sdv/lite/tabular.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amontanez24 amontanez24 changed the title Issue 983 user guide fixes user guide fixes Sep 1, 2022
@amontanez24 amontanez24 changed the title user guide fixes User Guide code fixes Sep 1, 2022
fealho
fealho approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

katxiao
katxiao approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@katxiao katxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@amontanez24 amontanez24 merged commit 28c5ee5 into master Sep 1, 2022
@amontanez24 amontanez24 deleted the issue-983-user-guide-fixes branch September 1, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fealho fealho fealho approved these changes

@katxiao katxiao katxiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Guide code fixes
4 participants
@amontanez24 @codecov-commenter @katxiao @fealho