Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot sample after loading a model with custom constraint #991

Conversation

pvk-developer
Copy link
Member

Resolves #984

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #991 (afcf057) into master (b441913) will increase coverage by 0.01%.
The diff coverage is 85.71%.

❗ Current head afcf057 differs from pull request most recent head e726fdd. Consider uploading reports for the commit e726fdd to get more accurate results

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
+ Coverage   70.22%   70.23%   +0.01%     
==========================================
  Files          38       38              
  Lines        2851     2849       -2     
==========================================
- Hits         2002     2001       -1     
+ Misses        849      848       -1     
Impacted Files Coverage Δ
sdv/timeseries/base.py 0.00% <0.00%> (ø)
sdv/relational/base.py 30.88% <33.33%> (ø)
sdv/tabular/base.py 83.85% <33.33%> (ø)
sdv/constraints/tabular.py 99.73% <100.00%> (+0.25%) ⬆️
sdv/lite/tabular.py 100.00% <100.00%> (ø)
sdv/sdv.py 89.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pvk-developer pvk-developer marked this pull request as ready for review September 1, 2022 18:10
@pvk-developer pvk-developer requested a review from a team as a code owner September 1, 2022 18:10
@pvk-developer pvk-developer requested review from fealho and amontanez24 and removed request for a team September 1, 2022 18:10
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few integration tests that need to be updated. Besides that this lgtm. Seems like a straight forward switch

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pvk-developer pvk-developer merged commit 7a70db6 into master Sep 2, 2022
@pvk-developer pvk-developer deleted the issue-984-cannot-sample-after-loading-a-model-with-custom-constraint branch September 2, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot sample after loading a model with custom constraints: TypeError
4 participants