-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot sample after loading a model with custom constraint #991
Cannot sample after loading a model with custom constraint #991
Conversation
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
+ Coverage 70.22% 70.23% +0.01%
==========================================
Files 38 38
Lines 2851 2849 -2
==========================================
- Hits 2002 2001 -1
+ Misses 849 848 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are a few integration tests that need to be updated. Besides that this lgtm. Seems like a straight forward switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Resolves #984