Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Ui: Make the ResultDisplay red on command failure #799

Closed
wants to merge 5 commits into from
Closed

Ui: Make the ResultDisplay red on command failure #799

wants to merge 5 commits into from

Commits on Aug 9, 2018

  1. CommandBox: Store result's success status in NewResultAvailableEvent 

    NewResultAvailableEvent only stores the message of the command
execution. It does not store the success status.

Subscribers such as ResultDisplay requires the success status to
work.

As part of teaching ResultDisplay to update the display according to
the success status, let's modify NewResultAvailableEvent to store
the success status.
    @yamgent
    yamgent committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    bb96e3c View commit details
    Browse the repository at this point in the history

  2. CommandBoxTest: Verify status stored in NewResultAvailableEvent 

    CommandBox stores the success status of command execution in
NewResultAvailableEvent.

This behavior is not verified by any of the unit tests for CommandBox.

Let's update the unit tests in CommandBoxTest to verify that
behavior.
    @yamgent
    yamgent committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    5ef56c5 View commit details
    Browse the repository at this point in the history

  3. ResultDisplay: Display message in red when command fails 

    The ResultDisplay shows the same color (white) regardless of whether
the command executed by the user succeeded or failed.

Changing the color of the message when the command execution failed
gives a clear visual signal to the user that he made a mistake, and
that the message shown is an error, rather than a normal message.

Let's modify ResultDisplay to display the message in red when the
command execution fails.
    @yamgent
    yamgent committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    3c79d31 View commit details
    Browse the repository at this point in the history

  4. ResultDisplayTest: Verify display turns red on error 

    ResultDisplay will turn red when command execution fails.

This behavior is not verified by any of the unit tests for ResultDisplay.

Let's update the unit tests in ResultDisplayTest to verify that
behavior.
    @yamgent
    yamgent committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    ca028a4 View commit details
    Browse the repository at this point in the history

  5. AddressBookSystemTest: Verify that ResultDisplay style changes 

    The ResultDisplay style changes if there is an error in command
execution.

This behavior is not verified by any system tests.

Let's update the system tests to verify that.
    @yamgent
    yamgent committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    fc363ad View commit details
    Browse the repository at this point in the history