Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft config filename interface ideas #669

Merged
merged 17 commits into from
Aug 26, 2022
Merged

Draft config filename interface ideas #669

merged 17 commits into from
Aug 26, 2022

Conversation

vulder
Copy link
Contributor

@vulder vulder commented Aug 21, 2022

resolves se-sic/VaRA#843

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #669 (56dd583) into vara-dev (5bbbdc6) will increase coverage by 0.20%.
The diff coverage is 87.05%.

@@             Coverage Diff              @@
##           vara-dev     #669      +/-   ##
============================================
+ Coverage     66.70%   66.90%   +0.20%     
============================================
  Files           291      291              
  Lines         22134    22275     +141     
============================================
+ Hits          14764    14903     +139     
- Misses         7370     7372       +2     
Impacted Files Coverage Δ
tests/paper/test_case_study.py 100.00% <ø> (ø)
tests/tools/test_driver_casestudy.py 100.00% <ø> (ø)
varats/varats/experiments/base/just_compile.py 51.35% <0.00%> (+1.35%) ⬆️
...rats/experiments/phasar/global_analysis_compare.py 42.85% <0.00%> (ø)
...periments/phasar/ide_linear_constant_experiment.py 46.34% <0.00%> (+1.10%) ⬆️
...varats/experiments/szz/szz_unleashed_experiment.py 45.78% <ø> (ø)
...varats/experiments/vara/blame_report_experiment.py 58.00% <0.00%> (ø)
...rats/experiments/vara/blame_verifier_experiment.py 47.36% <0.00%> (ø)
...arats/experiments/vara/commit_report_experiment.py 38.46% <0.00%> (ø)
...ats/varats/experiments/vara/feature_perf_runner.py 37.73% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vulder vulder marked this pull request as ready for review August 26, 2022 12:15
@vulder vulder requested a review from boehmseb August 26, 2022 12:15
Copy link
Member

@boehmseb boehmseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Only some smaller discussion points here and there.

.pylintrc Outdated Show resolved Hide resolved
varats-core/varats/revision/revisions.py Outdated Show resolved Hide resolved
varats-core/varats/revision/revisions.py Show resolved Hide resolved
varats-core/varats/report/report.py Show resolved Hide resolved
varats-core/varats/report/report.py Outdated Show resolved Hide resolved
varats-core/varats/report/report.py Show resolved Hide resolved
varats-core/varats/paper/case_study.py Outdated Show resolved Hide resolved
varats/varats/data/data_manager.py Outdated Show resolved Hide resolved
@vulder vulder requested a review from boehmseb August 26, 2022 15:24
@vulder vulder merged commit bbf38b7 into vara-dev Aug 26, 2022
@vulder vulder deleted the f-ConfigFilename branch August 26, 2022 16:24
Sinerum pushed a commit that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants