Allow empty offset class

M include/vara/Feature/FeatureSourceRange.h M unittests/Feature/FeatureSourceRange.cpp
se-sic · Sep 4, 2023 · 387e0cb · 387e0cb
1 parent c6374ff
commit 387e0cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/include/vara/Feature/FeatureSourceRange.h b/include/vara/Feature/FeatureSourceRange.h
@@ -158,6 +158,9 @@ class FeatureSourceRange {
 
     static llvm::SmallVector<llvm::StringRef, 1>
     splitClass(llvm::StringRef Class) {
+      if (Class.empty()) {
+        return {};
+      }
       llvm::SmallVector<llvm::StringRef, 1> Split;
       Class.split(Split, "::");
       return Split;

diff --git a/unittests/Feature/FeatureSourceRange.cpp b/unittests/Feature/FeatureSourceRange.cpp
@@ -133,6 +133,7 @@ TEST(FeatureMemberOffset, individualAccessors) {
   EXPECT_EQ(Member.value().className(0), "bar");
   EXPECT_EQ(Member.value().className(1), "foo");
   EXPECT_EQ(Member.value().memberName(), "member");
+  EXPECT_EQ(Member.value().nestingDepth(), 2);
 }
 
 TEST(FeatureMemberOffset, anonymous) {
@@ -143,6 +144,7 @@ TEST(FeatureMemberOffset, anonymous) {
   EXPECT_EQ(Member->toString(), "::member");
   EXPECT_EQ(Member.value().className(), "");
   EXPECT_EQ(Member.value().memberName(), "member");
+  EXPECT_EQ(Member.value().nestingDepth(), 0);
 }
 
 TEST(FeatureMemberOffset, comparison) {