Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Add model execution #84

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add model execution #84

wants to merge 10 commits into from

Conversation

ziegltob
Copy link

Added model_executor.py to execute a simulation with trained models

Copy link
Contributor

@alessiogambi alessiogambi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking at your code and I have the following comments:

  • The driving agent used by DeepHyperion is Dave2, so you should name it this way. DeepHyperion is a test generator.
  • I do not understand why the load_model and predict are abstract methods. If the ModelExecutor is supposed to be abstract, then probably you should rename it as AbstractModelExecutor? Also this name does not really tell that the Model is indeed a Deep Neural Network, so probably should rename it altogether.
  • There a typo in the name of the guideline file
  • The oracles (_is_the_car_moving) should be placed in the AbstractExecutor class, or even better provided/registered using DependencyInjection

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants