-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUTORIALS: Reorganise tutorials and add inline solutions #106
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <bbrcknl@gmail.com>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than changing copyright holders, overall it seems fine. I haven't seen it rendered yet though.
|
||
``` | ||
/*-- filter TaskContent("hello", TaskContentType.BEFORE, subtask="event-task3") -*/ | ||
/* TASK 3: the event interfaces */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the discontinuous task numbering, maybe it makes sense on the rendered page. Why isn't this TASK 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this numbering in there so as not to mess with the original tutorials. The ordering makes more sense if you look at the .c
, .camkes
and .txt
files that are generated from the .md
file. Should we mention this on the tutorial pages?
The current camkes tutorial overview (https://docs.sel4.systems/Tutorials/#camkes-tutorials) points to a slide presentation, which is no longer available and may have had more detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The presentations still seem to be available here: https://github.com/seL4/sel4-tutorials/tree/master/docs. It's in old D61 layout, but the content is still Ok, I think.
tutorials/hello-world/hello-world.md
Outdated
/*? macros.simulate_block() ?*/ | ||
### Run Hello, World using QEMU | ||
|
||
The final image can be run *inside* the container using the command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QEMU is not a container, it is a hardware CPU emulator. The text below already says that it will be run within QEMU simulator, so I'd keep the original text "The final image can be run by:".
tutorials/hello-world/hello-world.md
Outdated
Once you have made your change, rerun `ninja` to rebuild the project: | ||
Once you have made your change, use Terminal B to rebuild the project. | ||
|
||
*Hint:* Remember to exit the QEMU siumator before rerunning the project with `ctrl-A,x`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Hint:* Remember to exit the QEMU siumator before rerunning the project with `ctrl-A,x`. | |
*Hint:* Remember to exit the QEMU simulator before rerunning the project with `ctrl-A,x`. |
tutorials/hello-world/hello-world.md
Outdated
|
||
*Hint:* Remember to exit the QEMU siumator before rerunning the project with `ctrl-A,x`. | ||
|
||
Then rebuild using ninja and run the simulator again: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this one supposed to replace the next line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed line 208
tutorials/mcs/mcs.md
Outdated
'mcs-server','mcs-badge','mcs-fault']) ?*/ | ||
|
||
This tutorial presents the features in the upcoming MCS extensions for seL4, which are currently undergoing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tutorial presents the features in the upcoming MCS extensions for seL4, which are currently undergoing | |
This tutorial presents the features in the Mixed-Criticality System (MCS) extensions for seL4, which are currently undergoing |
@@ -1,7 +1,7 @@ | |||
<!-- | |||
Copyright 2021 Michael Neises | |||
|
|||
SPDX-License-Identifier: BSD-2-Clause | |||
SPDX-License-Identifier: CC-BY-SA-4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC-BY-SA-4.0 seems to be compatible with BSD-2-Clause, so the above change is probably legal.
Doesn't seem very polite to do though, especially if there are no other changes.
tutorials/dynamic-2/dynamic-2.md
Outdated
|
||
/*- filter ExcludeDocs() -*/ | ||
/*? ExternalFile("CMakeLists.txt") ?*/ | ||
``` | ||
/*-- filter File("main.c") -*/ | ||
/* | ||
* Copyright 2017, Data61, CSIRO (ABN 41 687 119 230) | ||
* Copyright 2024, seL4 Project a Series of LF Projects, LLC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legally dubious.
tutorials/dynamic-3/dynamic-3.md
Outdated
/*-- filter ExcludeDocs() -*/ | ||
/*? ExternalFile("CMakeLists.txt") ?*/ | ||
``` | ||
/*-- filter File("main.c") -*/ | ||
/* | ||
* Copyright 2017, Data61, CSIRO (ABN 41 687 119 230). | ||
* Copyright 2024, seL4 Project a Series of LF Projects, LLC.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legally dubious.
tutorials/dynamic-3/dynamic-3.md
Outdated
@@ -640,9 +697,9 @@ int main(void) { | |||
/*-- endfilter -*/ | |||
/*-- filter File("app.c") -*/ | |||
/* | |||
* Copyright 2017, Data61, CSIRO (ABN 41 687 119 230). | |||
* Copyright 2024, seL4 Project a Series of LF Projects, LLC.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legally dubious.
tutorials/dynamic-4/dynamic-4.md
Outdated
@@ -435,9 +485,9 @@ int main(void) { | |||
/*-- endfilter -*/ | |||
/*-- filter File("client.c") -*/ | |||
/* | |||
* Copyright 2017, Data61, CSIRO (ABN 41 687 119 230). | |||
* Copyright 2024, seL4 Project a Series of LF Projects, LLC.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legally dubious.
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
@Indanz |
Signed-off-by: Birgit Brecknell <b@brck.nl>
Dynamic libraries filenames need changing. It's on my to-dos for Friday. |
Co-authored-by: Gerwin Klein <gerwin.klein@proofcraft.systems> Signed-off-by: bbrcknl <32238793+bbrcknl@users.noreply.github.com>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
ed0c2e1
to
2955796
Compare
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
Signed-off-by: Birgit Brecknell <b@brck.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this gargantuan job!
I checked the rendered pages and the diff, those look good. I haven't checked whether the commit history makes sense or not. If it's too much of a mess we can always squash it.
The updates in this PR were written in conjunction with those in seL4/docs#231
The aim of both PRs is:
To arrange the tutorial material on the docsite such that it is clear and easy to follow. Inspired by the Rust book https://doc.rust-lang.org/book/, the user can see the chapters in the index on the left, and go straight to the sections that they need.
Specifically, the updates on the docsite provide:
The tutorials have been slightly rewritten to:
Remaining issues:
A note on using the rewritten docsite (from seL4/docs#231):
While the docsite in this PR has the new tutorial layout, the Makefile clones the old tutorials from https://github.com/seL4/sel4-tutorials.
You’ll need to integrate the updated tutorials (from this PR) in the Makefile from seL4/docs#231
I can’t offer code for this because I’m a Makefile noob. I tested the new tutorials by having the Makefile call in and manipulate tutorial files from local directories.