Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding sponsors, updating logo to SVG, and restructure a bit #282

Merged
merged 6 commits into from
Jul 12, 2023
Merged

adding sponsors, updating logo to SVG, and restructure a bit #282

merged 6 commits into from
Jul 12, 2023

Conversation

june-andronick
Copy link
Contributor

No description provided.

@june-andronick
adding sponsors, updating logo to SVG, and restructure a bit
e39bd8f 
Signed-off-by: June Andronick <june@sel4.systems>
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Preview your changes here

The link checker found some issues! Review them here

@june-andronick
Copy link
Contributor Author

I'll only post when the sponsors appear correctly on LF side.
I'll fix the gitlint error during merge&squash. The link error is the same as before.

@june-andronick
Copy link
Contributor Author

@bbrcknl FYI, as part of this PR I have changes the way "Latest news" appears in the table of content at the top. Now the latest item appears at the position we will want it to be, and the Latest news is just a pointer to that. It should make things easier to update as more info is added

gernotheiser
gernotheiser reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@gernotheiser gernotheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for replacing the logo bitmap with vector graphics

@june-andronick
adding Collins
de0ab9a 
Signed-off-by: June Andronick <june@sel4.systems>
@github-actions
Copy link

Preview your changes here

The link checker found some issues! Review them here

@june-andronick
adding news item for sponsors
a705b79 
Signed-off-by: June Andronick <june@sel4.systems>
@github-actions
Copy link

Preview your changes here

The link checker found some issues! Review them here

@june-andronick
adding call for sponsors
3c119bf 
Signed-off-by: June Andronick <june@sel4.systems>
@github-actions
Copy link

Preview your changes here

The link checker found some issues! Review them here

@june-andronick june-andronick marked this pull request as ready for review July 11, 2023 14:19
@june-andronick
Copy link
Contributor Author

@gernotheiser I've added Collins and news items. Can you please approve?

@june-andronick
adding link to Minneapolis
1972e2a 
Signed-off-by: June Andronick <june@sel4.systems>
@june-andronick
Copy link
Contributor Author

@gernotheiser sorry just added a link to Minneapolis in news item on Collins :)

@github-actions
Copy link

Preview your changes here

The link checker found some issues! Review them here

@gernotheiser
Copy link
Member

I suggest increasing the size of the Collins logo on the news page, it's really tiny. Should probably be 50–100% wider to appear visually similar to the others.

@june-andronick
increase collins logo size on news
0a56b08 
Signed-off-by: June Andronick <june@sel4.systems>
@june-andronick
Copy link
Contributor Author

I suggest increasing the size of the Collins logo on the news page, it's really tiny. Should probably be 50–100% wider to appear visually similar to the others.

Done

@github-actions
Copy link

Preview your changes here

The link checker found some issues! Review them here

@june-andronick
Copy link
Contributor Author

@gernotheiser any other comment? Otherwise can you please approve?

@june-andronick june-andronick merged commit f23a973 into master Jul 12, 2023
7 of 9 checks passed
@june-andronick june-andronick deleted the sponsors branch July 12, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gernotheiser gernotheiser gernotheiser approved these changes

@bbrcknl bbrcknl Awaiting requested review from bbrcknl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@june-andronick @gernotheiser