Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added utils read.csv workaround for data download failing on windows #19

Merged
merged 3 commits into from
Jan 24, 2018

Conversation

seabbs
Copy link
Owner

@seabbs seabbs commented Jan 24, 2018

Fixes for transient download issue on windows. Added second attempt at downloading data using utils::read_csv see issue #18

@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #19 into master will decrease coverage by 0.11%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #19      +/-   ##
=========================================
- Coverage   95.81%   95.7%   -0.12%     
=========================================
  Files           8       8              
  Lines         311     326      +15     
=========================================
+ Hits          298     312      +14     
- Misses         13      14       +1
Impacted Files Coverage Δ
R/get_tb_burden.R 100% <100%> (ø) ⬆️
R/get_data_dict.R 100% <100%> (ø) ⬆️
R/get_data.R 95.74% <92.3%> (-1.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4101dc9...6f8bc76. Read the comment docs.

@seabbs
Copy link
Owner Author

seabbs commented Jan 24, 2018

Added more tests for work around and checking data is in the same format

@seabbs
Copy link
Owner Author

seabbs commented Jan 24, 2018

Updated documentation to reflect new testing arguements

@seabbs seabbs merged commit 90805b0 into master Jan 24, 2018
@seabbs seabbs deleted the fix_windows_data_download branch March 5, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant