bugfix: add platform value to container image list #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… container image;add some debug logs Signed-off-by: kakzhou719 <kakazhou719@163.com>
starnop
reviewed
Jul 12, 2023
| //handle image name | ||
| for _, image := range images { | ||
| named, err := ParseNormalizedNamed(image, "") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to parse image name:: %v", err) | ||
| } | ||
|
|
||
| //check if image exist | ||
| //check if image is duplicate |
There was a problem hiding this comment.
This judgment may be redundant, as the OCI pull process itself checks for the presence of the image layer.
In addition, there is a risk of misjudgment here.
There was a problem hiding this comment.
-
i wonder there is not redundant.
for example: input images["nginx:latest","docker.io/library/nginx:latest"], will be transformed ["docker.io/library/nginx:latest","docker.io/library/nginx:latest"], so we need to do deduplication，nothing to do with pull process logic. -
what risks here ? sorry i dont understand?
There was a problem hiding this comment.
Sorry, I thought we were doing the duplicate removal in the step of pulling image. Currently, it seems that only for the image name, which is OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews