Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle proxied image urls in seed-from-api #17

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

louis-pre
Copy link
Member

@louis-pre louis-pre commented Jul 22, 2024

seamapi/react#646

Images can be returned through Next's image processor, this PR allows getImageIdFromImageUrl to find image_id even when the image url is proxied by Next

@louis-pre louis-pre added the bug Something isn't working label Jul 22, 2024
@louis-pre louis-pre self-assigned this Jul 22, 2024
@seambot
Copy link
Collaborator

seambot commented Jul 22, 2024

Bundle dist size: 19M

@louis-pre louis-pre marked this pull request as ready for review July 22, 2024 18:28
@louis-pre louis-pre requested a review from razor-x July 22, 2024 18:28
@louis-pre
Copy link
Member Author

louis-pre commented Jul 22, 2024

Oops, I thought there were no tests for this file but there is.
I'll add one for a proxied url

@louis-pre louis-pre marked this pull request as draft July 22, 2024 18:36
@louis-pre louis-pre marked this pull request as ready for review July 22, 2024 19:01
@louis-pre louis-pre changed the title fix: Handle proxied image urls fix: Handle proxied image urls in seed-from-api Jul 22, 2024
src/lib/database/seed-from-api.ts Show resolved Hide resolved
@louis-pre louis-pre merged commit 4af79de into main Jul 22, 2024
16 checks passed
@louis-pre louis-pre deleted the fix/image-url-parser branch July 22, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants