Skip to content

feat: Add disableClimateSettingSchedules prop #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 6, 2024
Merged

feat: Add disableClimateSettingSchedules prop #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa0abce
feat: Add `disableScheduledClimates` prop
xplato Mar 5, 2024
18277dc
Add to `props`
xplato Mar 5, 2024
fe0c32b
Better `props` typing
xplato Mar 5, 2024
d2b2695
Add everywhere else
xplato Mar 5, 2024
a07bc23
Add to element
xplato Mar 5, 2024
e3bb929
Remove default specifier on all internal components
xplato Mar 5, 2024
b1070bb
Rename prop to `disableClimateSettingSchedules`
xplato Mar 5, 2024
2181635
Add default back to `ThermostatDeviceDetails` to avoid linter issue on
xplato Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/element.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const commonProps: R2wcProps<CommonProps> = {
disableEditAccessCode: 'boolean',
disableDeleteAccessCode: 'boolean',
disableResourceIds: 'boolean',
disableClimateSettingSchedules: 'boolean',
onBack: 'object',
className: 'string',
}
Expand Down
2 changes: 2 additions & 0 deletions src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export function AccessCodeDetails({
disableLockUnlock = false,
disableDeleteAccessCode = false,
disableResourceIds = false,
disableClimateSettingSchedules,
onBack,
className,
}: AccessCodeDetailsProps): JSX.Element | null {
Expand All @@ -69,6 +70,7 @@ export function AccessCodeDetails({
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={() => {
selectDevice(null)
}}
Expand Down
4 changes: 4 additions & 0 deletions src/lib/seam/components/AccessCodeTable/AccessCodeTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export function AccessCodeTable({
disableLockUnlock = false,
disableDeleteAccessCode = false,
disableResourceIds = false,
disableClimateSettingSchedules,
}: AccessCodeTableProps): JSX.Element {
useComponentTelemetry('AccessCodeTable')

Expand Down Expand Up @@ -147,6 +148,7 @@ export function AccessCodeTable({
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={() => {
setSelectedEditAccessCodeId(null)
}}
Expand Down Expand Up @@ -182,6 +184,7 @@ export function AccessCodeTable({
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={() => {
setSelectedViewAccessCodeId(null)
}}
Expand All @@ -202,6 +205,7 @@ export function AccessCodeTable({
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={toggleAddAccessCodeForm}
className={className}
onSuccess={() => {
Expand Down
2 changes: 2 additions & 0 deletions src/lib/seam/components/ClimateSettingScheduleDetails/ClimateSettingScheduleDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export function ClimateSettingScheduleDetails({
disableCreateAccessCode,
disableEditAccessCode,
disableResourceIds = false,
disableClimateSettingSchedules,
}: ClimateSettingScheduleDetailsProps): JSX.Element | null {
useComponentTelemetry('ClimateSettingScheduleDetails')

Expand Down Expand Up @@ -65,6 +66,7 @@ export function ClimateSettingScheduleDetails({
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={() => {
selectDevice(null)
}}
Expand Down
2 changes: 2 additions & 0 deletions src/lib/seam/components/ClimateSettingScheduleTable/ClimateSettingScheduleTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export function ClimateSettingScheduleTable({
disableCreateAccessCode,
disableEditAccessCode,
disableResourceIds = false,
disableClimateSettingSchedules,
}: ClimateSettingScheduleTableProps): JSX.Element {
useComponentTelemetry('ClimateSettingScheduleTable')

Expand Down Expand Up @@ -125,6 +126,7 @@ export function ClimateSettingScheduleTable({
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={() => {
setSelectedViewClimateSettingScheduleId(null)
}}
Expand Down
4 changes: 3 additions & 1 deletion src/lib/seam/components/DeviceDetails/DeviceDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export function DeviceDetails({
disableResourceIds = false,
disableCreateAccessCode = false,
disableEditAccessCode = false,
disableClimateSettingSchedules = false,
onBack,
className,
}: DeviceDetailsProps): JSX.Element | null {
Expand All @@ -36,12 +37,13 @@ export function DeviceDetails({
return null
}

const props = {
const props: Omit<DeviceDetailsProps, 'deviceId'> = {
disableLockUnlock,
disableDeleteAccessCode,
disableResourceIds,
disableCreateAccessCode,
disableEditAccessCode,
disableClimateSettingSchedules,
onBack,
className,
}
Expand Down
2 changes: 2 additions & 0 deletions src/lib/seam/components/DeviceDetails/LockDeviceDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export function LockDeviceDetails(
disableEditAccessCode,
disableDeleteAccessCode,
disableResourceIds,
disableClimateSettingSchedules,
onBack,
className,
} = props
Expand Down Expand Up @@ -62,6 +63,7 @@ export function LockDeviceDetails(
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={toggleAccessCodesOpen}
className={className}
/>
Expand Down
40 changes: 22 additions & 18 deletions src/lib/seam/components/DeviceDetails/ThermostatDeviceDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export function ThermostatDeviceDetails({
disableEditAccessCode,
disableDeleteAccessCode,
disableResourceIds = false,
disableClimateSettingSchedules = false,
}: ThermostatDeviceDetailsProps): JSX.Element | null {
const [climateSettingsOpen, setClimateSettingsOpen] = useState(false)

Expand All @@ -65,6 +66,7 @@ export function ThermostatDeviceDetails({
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={() => {
setClimateSettingsOpen(false)
}}
Expand All @@ -91,25 +93,27 @@ export function ThermostatDeviceDetails({

<div className='seam-thermostat-device-details'>
<DetailSectionGroup>
<DetailSection
label={t.scheduledClimates}
tooltipContent={t.scheduledClimatesTooltip}
>
<DetailRow
label={
climateSettingSchedules == null
? t.viewingClimateSchedules
: `${climateSettingSchedules.length} ${climateSettingSchedulesLabel}`
}
onClick={() => {
setClimateSettingsOpen(true)
}}
{!disableClimateSettingSchedules && (
<DetailSection
label={t.scheduledClimates}
tooltipContent={t.scheduledClimatesTooltip}
>
<div className='seam-detail-row-rotated-icon'>
<ChevronWideIcon />
</div>
</DetailRow>
</DetailSection>
<DetailRow
label={
climateSettingSchedules == null
? t.viewingClimateSchedules
: `${climateSettingSchedules.length} ${climateSettingSchedulesLabel}`
}
onClick={() => {
setClimateSettingsOpen(true)
}}
>
<div className='seam-detail-row-rotated-icon'>
<ChevronWideIcon />
</div>
</DetailRow>
</DetailSection>
)}

<DetailSection
label={t.currentSettings}
Expand Down
2 changes: 2 additions & 0 deletions src/lib/seam/components/DeviceTable/DeviceTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export function DeviceTable({
disableEditAccessCode = false,
disableDeleteAccessCode = false,
disableResourceIds = false,
disableClimateSettingSchedules = false,
onBack,
className,
}: DeviceTableProps = {}): JSX.Element {
Expand Down Expand Up @@ -112,6 +113,7 @@ export function DeviceTable({
disableEditAccessCode={disableEditAccessCode}
disableDeleteAccessCode={disableDeleteAccessCode}
disableResourceIds={disableResourceIds}
disableClimateSettingSchedules={disableClimateSettingSchedules}
onBack={() => {
setSelectedDeviceId(null)
}}
Expand Down
1 change: 1 addition & 0 deletions src/lib/seam/components/common-props.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export interface RequiredCommonProps {
disableEditAccessCode: boolean | undefined
disableLockUnlock: boolean | undefined
disableResourceIds: boolean | undefined
disableClimateSettingSchedules: boolean | undefined
}

export type CommonProps = Partial<RequiredCommonProps>
Expand Down