feat: Add snackbars for toggling lock status #678
Conversation
| setVariant(variant) | ||
| setVisible(true) | ||
| }, []), | ||
| SnackbarNode, |
There was a problem hiding this comment.
If we are going to keep this snackbar hook, can we just rename this to ToggleLockSnackbar instead of the generic SnackbarNode?
| setVisible(false) | ||
| }} | ||
| message={ | ||
| variant === 'success' ? t.successfullyUpdated : t.failedToUpdate |
There was a problem hiding this comment.
Does this pattern mean we'll need a new hook (and file) for every single snackbar going forward? or maybe we only create one if it is being used in multiple places?
IMO duplicating seems simpler here instead of a separate hook.
There was a problem hiding this comment.
@razor-x any thoughts on this?
There was a problem hiding this comment.
the reason why I created a hook is there is two different components that are toggling snackbars. In order not to duplicate the code I created a hook for it.
There was a problem hiding this comment.
Yea, I think we're ok to just duplicate it. Otherwise this pattern could result in too many hooks/files, for every snackbar type.
No description provided.