Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic IPs quotas_name #4

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Elastic IPs quotas_name #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d77e81a
EIPs quota names changed
sean-zou Apr 8, 2021
8f05f4d
Fix tests as well
sean-zou Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions awslimitchecker/services/ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ def _get_limits_networking(self):
limit_type='AWS::EC2::EIP',
limit_subtype='AWS::EC2::VPC',
ta_service_name='VPC', # TA shows this as VPC not EC2
quotas_name='Number of EIPs - VPC EIPs'
quotas_name='EC2-VPC Elastic IPs'
)
# the EC2 limits screen calls this 'EC2-Classic Elastic IPs'
# but Trusted Advisor just calls it 'Elastic IP addresses (EIPs)'
Expand All @@ -767,7 +767,7 @@ def _get_limits_networking(self):
self.warning_threshold,
self.critical_threshold,
limit_type='AWS::EC2::EIP',
quotas_name='Elastic IP addresses for EC2-Classic'
quotas_name='EC2-Classic Elastic IPs'
)
limits['VPC security groups per elastic network interface'] = AwsLimit(
'VPC security groups per elastic network interface',
Expand Down
4 changes: 2 additions & 2 deletions awslimitchecker/tests/services/test_ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ def test_simple(self):
].quotas_service_code == 'ec2'
assert limits[
'VPC Elastic IP addresses (EIPs)'
].quota_name == 'Number of EIPs - VPC EIPs'
].quota_name == 'EC2-VPC Elastic IPs'
assert limits[
'VPC Elastic IP addresses (EIPs)'
].quotas_unit == 'None'
Expand All @@ -904,7 +904,7 @@ def test_simple(self):
].quotas_service_code == 'ec2'
assert limits[
'Elastic IP addresses (EIPs)'
].quota_name == 'Elastic IP addresses for EC2-Classic'
].quota_name == 'EC2-Classic Elastic IPs'
assert limits[
'Elastic IP addresses (EIPs)'
].quotas_unit == 'None'
Expand Down