Fully delegate installation to rstantools #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andrjohns! I'll get a version off to CRAN shortly. |
|
We need this merged PR to be released to CRAN in order to release the StanHeaders that has been years in the making but is still years behind the current Stan development branch. Please do so this week. |
|
Apologies. It was auto-rejected because of the note: which I believe gets generated in the Makevars files by rstantools and I dropped the ball asking CRAN to consider this a false positive. I have replied to CRAN and will stay on top of this. |
|
An updated version of rstantools was released today which should resolve that issue for you |
|
Thanks. I updated to the latest rstantools and sent to CRAN. I just got the "on its way to CRAN" reply now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates your package to fully delegate the installation/compilation of stan models to rstantools.
There were also several test/check errors due to a missing
offsetargument to thepredictfunction, so I've also added default zero values to those calls so that the checks & tests pass