Add Chrome, Edge, and Edge Dev on Windows #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, looks good 👍 , didnt know expandvars could handle the localappdata on windows could you update the list of browsers in the readme and link to the edge/edge dev websites (Im not sure if edge dev is just the dev channel or something else?) |
|
will push a new version tonight |
Closed
|
Thanks! Yeah Edge Dev is just a prerelease channel (the one I use most often). I was pleasantly surprised that I didn't have to jump through hoops to resolve %LocalAppData% properly. I have a few other browsers on another machine, I might throw another PR out with the rest of the paths for Windows just out of principle 😁. |
|
That would be great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exporting from Chrome, Edge, and Edge's Dev prerelease builds on Windows.