Deprecate longwinded method names #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanhandley
force-pushed
the
deprecate_h3_prefix_methods
branch
from
0ca1ab8 to
f81c399
Compare
seanhandley
changed the title
seanhandley
force-pushed
the
deprecate_h3_prefix_methods
branch
8 times, most recently
from
14a79ea to
090a0d7
Compare
seanhandley
force-pushed
the
deprecate_h3_prefix_methods
branch
from
090a0d7 to
ccb1626
Compare
seanhandley
force-pushed
the
deprecate_h3_prefix_methods
branch
from
ccb1626 to
ebd69a7
Compare
seanhandley
force-pushed
the
deprecate_h3_prefix_methods
branch
from
ebd69a7 to
2b4637f
Compare
|
Rebasing with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #58
Some of the method names could be simplified, in keeping with the Ruby naming conventions.
Changes
Still thinking about some of these 🤔
h3_to_parent=>parentmax_h3_to_children_size=>max_childrenh3_to_children=>childrenh3_resolution=>resolutionh3_base_cell=>base_cellstring_to_h3=>from_stringh3_pentagon?=>pentagon?h3_res_class_3?=>class_3_resolution?h3_valid?=>valid?h3_to_string=>to_stringh3_faces=>facesgeo_to_h3=>from_geo_coordinatesh3_to_geo=>to_geo_coordinatesh3_to_geo_boundary=>to_boundarynum_hexagons=>hexagon_countres_0_index_count=>base_cell_countres_0_indexes=>base_cellsh3_distance=>distanceh3_line_size=>line_sizeh3_line=>lineh3_indexes_neighbors?=>neighbors?h3_unidirectional_edge_valid?=>unidirectional_edge_valid?h3_unidirectional_edge=>unidirectional_edgeh3_indexes_from_unidirectional_edge=>origin_and_destination_from_unidirectional_edgeh3_unidirectional_edges_from_hexagon=>unidirectional_edges_from_hexagonh3_unidirectional_edge_boundary=>unidirectional_edge_boundary