Branching API - initial draft #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanimam
reviewed
Sep 16, 2024
Comment on lines
+51
to
+52
| // TODO: should we delete the map entry here? Probably yes? | ||
| viewToCheckoutMap.delete(forkedTreeView); |
There was a problem hiding this comment.
I could see use cases where we'd want to restore a branch, and maybe this could be something like GIT where you could see different branches and manually delete them if they're no longer useful. That being said this should be fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial draft of exposing a basic branching API in the FluidLLM library.
@internal, which required moving thegetViewForForkedBranchfunction from test code to source code.branch()andmerge()functions in the FluidLLM library, which operate in terms of existing public SharedTree APIs, so users can actually leverage them in applications today.Reviewer Guidance
The review process is outlined on this wiki page.