Use firefox native click behavior #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing out lusakasa#337, but noticed that it broke the normal clicking. So I did a bit of snooping.
I'm just looking at all this code for the first time so could be entirely off-base, but seems like the click event should still be passed through to use Firefox's native click behavior. Then, the other work-arounds to manually implement click behavior can be conditioned upon the firefox version.
Borrowed version-checking code from lusakasa#337. The
firefoxNoNativeClickconst is duplicated between files which is clearly distasteful. Suggestions welcomed.As far as I can tell on my machine (Ubuntu 20.04 and Firefox 96), things in are now working quite smoothly. Although, I'd be surprised if I'm not glossing over any nuances.
Happy to PR to parent repo if desired.