Update env logger #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@complexspaces maybe update this to env-logger 0.9? @seanmonstar ping? |
complexspaces
force-pushed
the
update-env-logger
branch
from
c90f3f9
to
204b87d
Compare
|
@djc Thanks for the ping! I've updated this branch to use |
|
@seanmonstar Friendly ping on this PR, if you have the bandwidth available. |
seanmonstar
approved these changes
Mar 31, 2022
|
Oh noes, this repo is still configured with old CI... Sigh, need to update to GH Actions. |
|
@complexspaces @seanmonstar now that GitHub actions is setup can we rebase on master and merge this in? |
complexspaces
force-pushed
the
update-env-logger
branch
from
7575aaa
to
150ea02
Compare
|
I've rebased onto the latest |
|
@seanmonstar @praveenperera Sorry for the delay. I've ran |
Open
|
Can you create a release that includes this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
env-loggerto version0.9since it's been out for a few months now (and 0.8 even longer).The only upstream breaking change is the MSRV being increased to
1.41. However, while I don't see a MSRV forpretty_env_logger, its doubtful it will break any users as Debian stable ships a minimum of 1.41.1 and the majority of users are on newer compiler versions.Closes #50