Add Gzip decoding automatically to Response

[seanmonstar]

No description provided.

[echochamber]

Would using https://github.com/alexcrichton/flate2-rs work here?

[seanmonstar]

Yes, that would probably be a good crate to use.

Internally, we'd adjust the Response struct to be an enum, with variants
for plain text and gzip, and automatically pick which one to use after
inspecting headers.

On Tue, Nov 15, 2016, 10:07 PM Jason Schein notifications@github.com
wrote:

Would using https://github.com/alexcrichton/flate2-rs work here?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADJF7k25RH2-vZdW1dTqO11tgq3EMeVks5q-p26gaJpZM4KYB2F
.

[echochamber]

Cool, I'll give this one a go over the weekend.

[echochamber]

Its been a while since I've written any Rust and I'm pretty novice when it comes low(er) level stuff, so I want to thoroughly test this to actually make sure it works before submitting a PR, but if you want to see my progress and provide any feedback, here is my local fork/branch.

[seanmonstar]

@echochamber feel free to submit a PR, it is actually far easier to comment and review it when it is a PR. PRs don't have to be perfect from the beginning :)

Regarding echochamber@fb399a2:

I realize I mispoke, I didn't meant to change the Response struct to an enum, but instead to change the inner field to hold an enum. By keeping it a struct and the internals a private field, we can add more helpers or refactor later and not break anyone. For example:

pub struct Response {
    inner: Decoder
}

enum Decoder {
    Plaintext(::hyper::client::Response),
    Gzip(GzipDecoder<::hyper::client::Response>),
} 

Not I haven't checked that that is exactly how you type a GzipDecoder.

Separately, it seems that we should be checking the Transfer-Encoding, not the Content-Encoding. See http://stackoverflow.com/questions/11641923/transfer-encoding-gzip-vs-content-encoding-gzip

[echochamber]

@echochamber feel free to submit a PR, it is actually far easier to comment and review it when it is a PR. PRs don't have to be perfect from the beginning :)

Opened a PR here #25

Thanks for the feedback and suggestions thus far. I'll try to have my PR reflect your suggestions this evening.

[seanmonstar]

Closed by #61